Open freemansw1 opened 3 weeks ago
Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.6.0 branch. A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.
Attention: Patch coverage is 90.47619%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 62.00%. Comparing base (
0ebee82
) to head (5a9190e
).
Files with missing lines | Patch % | Lines |
---|---|---|
tobac/feature_detection.py | 76.59% | 11 Missing :warning: |
tobac/utils/bulk_statistics.py | 78.57% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I should have noted that this fixes the merge conflicts (and the resulting test failures) from #462.
Thanks for sorting this! I realised after opening #462 that the merge was too complex to do online, so I have closed that now. I'll have a look through, as I noticed a number of non-conflicting instances where changes had been reverted by the merge in #462
We should hold off merging this until #465 is merged.
I couldn't figure out how to easily do this as part of #462 , so doing it in a separate PR, if that's ok @w-k-jones .
This PR merges the changes that are now in
main
(and fromRC_V1.5.x
) intoRC_v1.6.0
.