tobac-project / tobac

Tracking and object-based analysis of clouds
BSD 3-Clause "New" or "Revised" License
103 stars 54 forks source link

Fix CI issues due to old conda version #465

Closed freemansw1 closed 2 weeks ago

freemansw1 commented 3 weeks ago

This continues the work from #457 and fixes issues with a few of our CI workflows that broke from miniconda being depreciated.

Note that this is a PR to main per our policy of CI improvements

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.67%. Comparing base (343243f) to head (203e4fd). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #465 +/- ## ========================================== - Coverage 60.72% 60.67% -0.06% ========================================== Files 23 23 Lines 3537 3537 ========================================== - Hits 2148 2146 -2 - Misses 1389 1391 +2 ``` | [Flag](https://app.codecov.io/gh/tobac-project/tobac/pull/465/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tobac-project/tobac/pull/465/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | `60.67% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

freemansw1 commented 3 weeks ago

The notebook CI is failing due to an upstream issue with pyart that has been fixed and will be released as part of their next version (https://github.com/ARM-DOE/pyart/pull/1623). As a temporary fix, I've copied their fix over to pin xarray versions to <2024.10.0.

I have no clue what is happening to the lining workflow. I've tried to partially roll it back, but it seems to always grab the old version of the file. I'd appreciate some help here, if someone wants to take a look.

freemansw1 commented 3 weeks ago

I have no clue what is happening to the lining workflow. I've tried to partially roll it back, but it seems to always grab the old version of the file. I'd appreciate some help here, if someone wants to take a look.

Okay, apparently this is expected behavior: https://github.com/orgs/community/discussions/122045 . I suppose we just must trust that the CI will pass?