tobac-project / tobac

Tracking and object-based analysis of clouds
BSD 3-Clause "New" or "Revised" License
103 stars 54 forks source link

Feature: Documentation Revamp and Retheme #470

Open freemansw1 opened 1 week ago

freemansw1 commented 1 week ago

After #460, I started to poke around to figure out how to make things look better on our documentation. As it turns out, making the docs look and feel modern was really not all that much work. I also thought v1.6.0 would be an ideal time to produce new, modern-feeling documentation.

This represents just a first step. I have modified very little text, instead just reorganizing things into categories to fit the theme. Note that this is requested to be merged into a new dev_documentation_revamp branch, which comes off RC_v1.6.0. I'm putting this in a branch by itself to encourage more collaborative work on this; perhaps we can commit to that repo directly rather than doing it through PRs (until it is time to merge into the RC).

Given the somewhat unusual path here, I'm requesting relatively light reviews. We will continue to make updates before merging into the RC, I am at this point just seeking feedback on whether or not this is broadly fits what we are looking to do with our documentation.

github-actions[bot] commented 1 week ago

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the dev_documentation_revamp branch. A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.27%. Comparing base (0ebee82) to head (e786d22).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev_documentation_revamp #470 +/- ## ========================================================= Coverage 62.27% 62.27% ========================================================= Files 23 23 Lines 3690 3690 ========================================================= Hits 2298 2298 Misses 1392 1392 ``` | [Flag](https://app.codecov.io/gh/tobac-project/tobac/pull/470/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tobac-project/tobac/pull/470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | `62.27% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

freemansw1 commented 1 week ago

Looks really good! Happy for this to be merged into the docs development branch so further work can get started. Some thoughts, which can be addressed in later PRs:

  • API documentation has no subsections in the left side column

Yeah, I'll plan to fix that before the PR gets merged. Good call. I need to dig into that section some more.

  • The home page is a bit unclear now, as it is just a block of text. We should think about how to restructure it to more clearly direct users to the info they need. I quite like the way that the numpy and xarray docs homepage is structured

One reason I didn't do anything to the homepage is that I am not sure whether we should go for something like the xarray/numpy/metpy documentation or more of a highlight gallery like the ArviZ documentation (https://python.arviz.org/en/stable/). I am inclined for the latter, but I am open to either.