Page navigation support for timeline.

tobami / codespeed

A web application to monitor and analyze the performance of your code

Other

592 stars 125 forks source link

Page navigation support for timeline. #17

Closed smarr closed 13 years ago

smarr commented 13 years ago

Hi:

Would be great if the timeline could support page navigation, i.e., the browser's back-button. At the moment, you always return to the overview instead of a specific benchmark.

Thanks Stefan

tobami commented 13 years ago

That is a common problem with ajax-heavy web apps. You click on things, but stay the whole time in the same page/url. There are workarounds for it, but they are usually complex.

I found one interesting one: http://www.aplusdesign.com.au/blog/ajax-pagination-back-button/

Perhaps it is worth investigating.

smarr commented 13 years ago

Would be great if you could have a look at smarr/codespeed@7b72d43e20d59ee69b8227f636ac80464c44111a

I gave it a try, looks like it works nicely. But could use some testing...

tobami commented 13 years ago

Very cool. I'll test it later today

tobami commented 13 years ago

I tested your fork, and the back and forward buttons do work, it is pretty cool.

However, there is a bug: when I keep clicking on another benchmark, 1 out of 3 times all executables get deselected, resulting in no plot being displayed. And you can't select another executable. Also, when viewing a plot, if I try to select or deselect an exe, all get deselected and you can not select them any more, as described above.

That happened in Firefox 3.6 and Chrome 5.0 (here I got a blank plot every two changes of benchmark). What browser do you use?

smarr commented 13 years ago

I have fixed one issue with executables. They were not handled properly until now: smarr/codespeed@a23d105e6a0c5404aee83bc840e7b58428fd362e

Hope that also fixes the things you saw.

smarr commented 13 years ago

And two more fixes:

encoding of spaces was broken, fixed with an update to recent master of jQuery Address
revs setting was ignored due to inconsistent names

See smarr/codespeed@b79cc00749d0819635dcedfe152824dc81153bff

tobami commented 13 years ago

Yes, it is fixed now, great! How do you want to go about merging this?

smarr commented 13 years ago

Ehm, don't know. The changes should be fairly localized in timeline.html.

Do you want me to rebase them on what you currently have in your repo?

tobami commented 13 years ago

I guess I can do a manual diff then. Btw., what exact version of the jQuery Address plugin are you using? (also, you changed to non-minified)

smarr commented 13 years ago

Ok, sure.

I had to update to the latest code that is on github for that fix. It is not released yet, and thus not minified. And I did not bother to do so, so far. Will try to keep track of it and replace it once it has been released.

tobami commented 13 years ago

Closed by #45