search

tobami / codespeed

A web application to monitor and analyze the performance of your code
Other
593 stars 125 forks source link

Require Result fields #42

Open ghost opened 13 years ago

ghost commented 13 years ago

http://speed.twistedmatrix.com/timeline/ broke because we inserted some Results with empty date fields. Speedcenter doesn't care and feeds them to jqplot, resulting in: Uncaught TypeError: Object NaN has no method 'getTime' when rendering a graph (and consequently no graph).

Fields that break jqplot when empty should either be required on insert, or checked as non-null before being provided to jqplot. The latter might be preferable since it doesn't require a database alteration.

tobami commented 13 years ago

This is obviously a bug.

When saving results, if no date is provided Codespeed should add the current date as default value.