tobania / VSTS.Extension.SqlReportingServices

VSTS Extension for uploading SSRS Reports
MIT License
14 stars 20 forks source link

Mislabelled 'Local Dataset path' Field #21

Closed philipstratford closed 6 years ago

philipstratford commented 6 years ago

This could be me getting confused but I believe that the field which should be labelled 'Local Dataset path' is labelled as 'Local Datasource path'. The reasons I believe this to be the case are:

More broadly, the labelling in this extension really needs tidying up. It's completely inconsistent, and when the names of these fields are so similar anyway and there are lots of controls visible on the page, it can get pretty confusing. For example, the extension refers to both "Data Source" and "Datasource", and "Data Set and Dataset". For what it's worth, I believe that the correct terms are "Data Source" (two words) and "Dataset" (one word).

anton-kirschhock commented 6 years ago

Thanks for the comment! We will review it and come back with a solution

philipstratford commented 6 years ago

I've cloned the repo and fixed the problems with the labels and help text (for the Task that I use, at least). Can you allow me to make a Pull Request?

anton-kirschhock commented 6 years ago

@philipstratford You can submit the Pullrequest and we'll review it

philipstratford commented 6 years ago

Thanks, that's what I'm trying to do but it says I don't have permission to push changes to the repository. It's possible that I'm not doing it right, I don't use GitHub much.

anton-kirschhock commented 6 years ago

@philipstratford Giving you direct access, is not possible. But take a look at the usermanual: https://help.github.com/articles/about-pull-requests/

philipstratford commented 6 years ago

I'd missed the fact that I had to fork the repo first. Pull Request submitted!

anton-kirschhock commented 6 years ago

Build succeeded and latest version with your changes is available. Thanks for the contribution :)