search

tobania / VSTS.Extension.SqlReportingServices

VSTS Extension for uploading SSRS Reports
MIT License
14 stars 20 forks source link

Verbosing wrong variable? #35

Closed austin-best closed 6 years ago

austin-best commented 6 years ago

https://github.com/tobania/VSTS.Extension.SqlReportingServices/blob/e6b2de5ff562d0b75ab188a4ed6ac5eeab7e9912/SqlReportingServices/SqlReportingServicesDeployment/SqlReportingServicesDeployment.ps1#L125-L128

is L128 supposed to be $type?

anton-kirschhock commented 6 years ago

Good one, guess was a rename which we forgot

Op 4 jan. 2018 12:22 schreef "austin-best" notifications@github.com:

https://github.com/tobania/VSTS.Extension.SqlReportingServices/blob/ e6b2de5ff562d0b75ab188a4ed6ac5eeab7e9912/SqlReportingServices/ SqlReportingServicesDeployment/SqlReportingServicesDeployment .ps1#L125-L128

is L128 supposed to be $type?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tobania/VSTS.Extension.SqlReportingServices/issues/35, or mute the thread https://github.com/notifications/unsubscribe-auth/AEcni_b-J1nLvO9ls4a2wwvdOVsJLcT1ks5tHLRlgaJpZM4RS4OH .

anton-kirschhock commented 6 years ago

Ive reviewed your PR and it will go live at the next deploy