tobbelobb / hangprinter

A RepRap hanging from the ceiling
GNU General Public License v2.0
465 stars 97 forks source link

Added NEMA 23 motor parameters #16

Closed ghost closed 6 years ago

ghost commented 6 years ago

Adds options for NEMA 23 stepper motors for the mounts and gears.

tobbelobb commented 6 years ago

Hi @Cdagr!

Adding a Nema23 option is really useful.

Which lines of code are changed and which are copied?

I'd rather not include all that copied code because it gets hard to maintain. I used your Nema23 parameters and added Nema23 support in another way, see this commit.

It lets you type make nema23 to get the three nema23-adapted stls you need. Make in turn excutes the following commands:

mkdir -p openscad_stl_nema23
openscad -D Nema17_cube_width=56 \
         -D Nema17_screw_hole_width=66.61 \
         -D Nema17_ring_diameter=38 \
         -D Nema17_cube_height=56 \
         -D Nema17_shaft_radius=3.175 \
         -o openscad_stl_nema23/motor_gear.stl ./openscad_src/motor_gear.scad
openscad -D Nema17_cube_width=56 \
         -D Nema17_screw_hole_width=66.61 \
         -D Nema17_ring_diameter=38 \
         -D Nema17_cube_height=56 \
         -D Nema17_shaft_radius=3.175 \
         -o openscad_stl_nema23/motor_bracket.stl ./openscad_src/motor_bracket.scad
openscad -D Nema17_cube_width=56 \
         -D Nema17_screw_hole_width=66.61 \
         -D Nema17_ring_diameter=38 \
         -D Nema17_cube_height=56 \
         -D Nema17_shaft_radius=3.175 \
         -o openscad_stl_nema23/extruder_holder.stl ./openscad_src/extruder_holder.scad

I avoided creating variables with Nema23 in the name because I want Nema17 to still be the sole standard setup.

But I'm very interested in how your Nema23 setup will work out! Will you be posting progress somewhere on the web?

Best regards

ghost commented 6 years ago

I only added lines 16-23 in parameters.scad, and 226-235 in util.scad. Everything else is a copy, but I tweaked some other settings irrelevant to the motors based off supplies I could get more easily around me.

Your way seems much easier and more straightforward, thanks for adding it!

I'll be posting progress in a new branch called megaprinter in my fork soon, but later on I will likely post somewhere else that I'll link in that branch.

tobbelobb commented 6 years ago

Great! I'll watch for news about megaprinter.