search

tobegit3hub / pirate

Private admin dashboard for docker distribution
Creative Commons Zero v1.0 Universal
42 stars 4 forks source link

Fix #4 remove multi-language support #16

Closed sdd330 closed 9 years ago

sdd330 commented 9 years ago

Some clean up

larrycai commented 9 years ago

@tobegit3hub do you agree with this ? it looks seagull is used for normal user as well, which demands multi-language support.

pirate's user is more for enterprise user, can we remove this feature first ?

when we need, we bring it back in new way of translation (you mentioned once to redesign this)

is it ok ?

tobegit3hub commented 9 years ago

It's ok to me.

But I don't think we have to remove the code. We can simply use the normal string in html file and this is not contradictory.

larrycai commented 9 years ago

@sdd330 is it ok to keep the old translation if exists, and use normal string without translation for new string. thx.

sdd330 commented 9 years ago

For bring old translation back, I suggest we keep it in backlog currently It should be easy to bring it back base on the work done in seagull

larrycai commented 9 years ago

ok.

On Mon, Jan 12, 2015 at 4:47 PM, Yang Leijun notifications@github.com wrote:

For bring old translation back, I suggest we keep it in backlog currently It should be easy to bring it back base on the work done in seagull

— Reply to this email directly or view it on GitHub https://github.com/tobegit3hub/pirate/pull/16#issuecomment-69541432.

True software development embraces consistent inconsistency. blog: http://larrycaiyu.com/blog (en), http://larrycaiyu.com (chinese)

sdd330 commented 9 years ago

Multi-language support could be done using some server side technologies, keep it in one js will make the file very big, also hard to maintenance