search

tobegit3hub / pirate

Private admin dashboard for docker distribution
Creative Commons Zero v1.0 Universal
42 stars 4 forks source link

Add docker pull suggestion for #5 #17

Closed sdd330 closed 9 years ago

sdd330 commented 9 years ago

The ServerUrl seems not returned by backend, can you take a look before merge?

larrycai commented 9 years ago

it reports error

controllers/dockerregistryapi.go:230: config.ServerUrl undefined (type configuration has no field or method ServerUrl)

Code is not pushed complete

larrycai commented 9 years ago

Other comments for PR

  1. better to use PIRATE_URL_ALIAS instead of SERVER_URL. And it is ok to keep SERVER_URL, then u help to update README.md to make it is complete PR
  2. try to assign default value for this environment, like <registry server>, then we can see docker pull <registry server>/library/helloworld instead of docker pull /library/helloworld
  3. will be good to have button "Copy to clipboard" like ;-)

Wait for new PR to merge

sdd330 commented 9 years ago

I will change SERVER_URL to PIRATE_URL_ALIAS

sdd330 commented 9 years ago

Updated

larrycai commented 9 years ago

@sdd330 thank, almost close to 0.2.0 release