odroid-5.12.y: overlay breaks build

DylanVanAssche commented 3 years ago

I tried to build the odroid-5.12.y branch on a musl Alpine based system (postmarketOS). I couldn't get it working at first until I noticed that Armbian doesn't include the overlay patches: https://github.com/armbian/build/pull/2847

I reverted them and now it builds and runs fine.

Is there something missing here?

tobetter commented 3 years ago

Do you meet the error when you build my repo and my branch? What commits are reverted?

DylanVanAssche commented 3 years ago

Yes, I built your repo with branch odroid-5.12.y and the build fails at the end when installing all things with:

  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos3250-artik5-eval.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos3250-monk.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos3250-rinato.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4210-i9100.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4210-origen.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4210-smdkv310.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4210-trats.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4210-universal_c210.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-i9300.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-i9305.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-itop-elite.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-n710x.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-odroidu3.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-odroidx.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-odroidx2.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-origen.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-p4note-n8010.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-smdk4412.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-tiny4412.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos4412-trats2.dtb
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos5250-arndale.dtb
make[2]: *** No rule to make target '/home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/overlays/spi0.dtbo', needed by '__dtbs_install'.  Stop.
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos5250-smdk5250.dtb
make[1]: *** [scripts/Makefile.dtbinst:38: arch/arm/boot/dts/overlays] Error 2
make[1]: *** Waiting for unfinished jobs....
  INSTALL arch/arm/crypto/aes-arm-bs.ko
  INSTALL /home/pmos/build/pkg/linux-odroid-hc2/usr/share/dtb/exynos5250-snow.dtb
  INSTALL arch/arm/crypto/aes-arm-ce.ko
  INSTALL arch/arm/crypto/aes-arm.ko
  INSTALL arch/arm/crypto/blake2b-neon.ko
make: *** [Makefile:1398: dtbs_install] Error 2
make: *** Waiting for unfinished jobs....
  INSTALL arch/arm/crypto/blake2s-arm.ko
  INSTALL arch/arm/crypto/chacha-neon.ko

I created 2 revert patches for the overlays patches (d5025e18d05e104770568225ec85beaf91c282f5 and fdb8fbfde3452687ff1982a9f72fd6c74181e6c1):

Armbian did the same by excluding both commits: https://github.com/armbian/build/tree/56a76727724b70c9d873f03a167093ec7890da40/patch/kernel/archive/odroidxu4-5.12/broken

Off-topic: I assume all of these patches are being upstreamed to the mainline kernel?

tobetter commented 3 years ago

Thanks, a fix for this issue has been uploaded. https://github.com/tobetter/linux/commit/4f75c10941ab9e2856598f82bbd417545bd41681

DylanVanAssche commented 3 years ago

I tried the latest commit, it builds and works fine now, thanks!

tobetter commented 3 years ago

Thank you.

tobetter / linux

odroid-5.12.y: overlay breaks build #28