search

tobetter / linux

Linux kernel source tree
Other
69 stars 30 forks source link

Wrong colors on monitor #37

Open Cheaterman opened 2 years ago

Cheaterman commented 2 years ago

Hi and thanks for all your hard work!

This patch seems faulty: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c193a003dc46ae601f46908b41d6f485b87db1ad

My screen reports YUV422 but if I have this patch on, colors are all wrong (green/purple) ; if I leave this patch out, colors are A-OK.

Thanks in advance :-) please do ask if you need additional info!

EDIT: It's worth noting I've been discussing this with Neil on IRC, and they think the patch is correct ; it's probably (as often apparently) a case of my TV firmware reporting incorrect support for YUV422, but I seem to be unable to find a way to fix it without reverting this patch...

Cheaterman commented 2 years ago

I forgot to follow-up on this issue, but Neil on IRC said the proper way to fix this issue is to reorder the valid output modes as follows: https://gist.github.com/Cheaterman/5091074626a546471b0d8a890094b4ce

This seems to be necessary on N2+ to get proper colors on most displays. Possibly add it to the patchset, @tobetter ? :-) (it was also needed on odroid-5.19.y branch)