search

tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.2k stars 229 forks source link

Layout: highlights when layout is not in default state #1006

Closed alexveden closed 6 months ago

alexveden commented 6 months ago

This pull request introduces a new option for highlighting non-default layout:

layout.highlight_if_not = us

Does the following: Default layout image

Non-default; image

Previous plugin behavior preserved, if option not set, no highlighting for both layouts.

alexveden commented 6 months ago

BTW, when I was working on layout module, it seems there are 2 layout.py in core and contrib dirs. Bumblebee-status picks the contrib verison, I don't know if this is an issue or intentional. Maybe more clarity is required in the docs.

tobi-wan-kenobi commented 6 months ago

Oh, I did not notice the issue regarding duplicate module names, I will certainly investigate that. Thanks for mentioning this and thanks for the cool PR!

tobi-wan-kenobi commented 6 months ago

This might be functionality that could be nice in the framework itself - add a highlight group if a widget does (not) have a certain value.