tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.2k stars 229 forks source link

fix(modules,core,nix): respect include and exclude correctly when using multiple aliases #1010

Closed jonasbadstuebner closed 4 months ago

jonasbadstuebner commented 4 months ago

I was experiencing weird behaviour of the nic module, when I was using it with aliases. I will try to explain what I mean.

Minimal reproducible:

[core]
modules = nic:wg,nic:eth,nic:wifi

[module-parameters]
wg.format = {intf}
wg.include = wg-01

eth.exclude = lo,virbr,docker,vboxnet,veth,br,.*:avahi,wg-01,wlan0
eth.format = {state}

wifi.include = wlan0
wifi.format = {ssid}

This caused my bar to switch back and forth, some settings were overwriting others and include was not working at all. Maybe if I would have overwritten the exclude to be all and then used include it would have worked. But for me this is unintuitive behaviour.

If you have questions about why I changed it the way I did, please ask me.

My i3-bar can now look like this: grafik

tobi-wan-kenobi commented 4 months ago

Great catch, an thank you very much for not only describing the error, but also supplying a fix!