tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.22k stars 228 forks source link

[modules]: introduce pamixer module #877

Closed FraSharp closed 2 years ago

FraSharp commented 2 years ago

Signed-off-by: FraSharp s23265@iisve.it

tobi-wan-kenobi commented 2 years ago

Looks good, many thanks! I have to admit I am slightly concerned about the proliferation of various different modules doing essentially the same thing (P.A. volume control), but I see the point of this module, like the simplicity of the code & ultimately believe in giving users a choice.

Thank you very much for your contribution!

SamTebbs33 commented 2 years ago

Perhaps extracting out common code and deriving individual modules from that would be good for reducing duplication. I'd be happy to do that but I don't have any experience with object orientated programming in python.