search

tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.2k stars 228 forks source link

Prebuilt C binary in source #883

Closed benthetechguy closed 2 years ago

benthetechguy commented 2 years ago

Instead of having an x86_64 Linux binary hanging around in your source, maybe it would be better to compile it at build time. There are other architectures out there, you know. It would be preferable if there were no C code in this Python module at all, because the built package could be architecture independent.

anarcat commented 2 years ago

agreed. this seems to converge towards #790 as well: there should be just one layout module, and I personally think it should be the python version, not the C stub.

(or, if it's a C stub, it should be a pyx stub. :)

tobi-wan-kenobi commented 2 years ago

I fully agree on both counts :)

tobi-wan-kenobi commented 2 years ago

Just removed everything precompiled and fall back to the python xkb module.

Now, I am waiting for the bug reports about broken layout module coming in :)

Thanks for your valuable input everyone!