search

tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.22k stars 228 forks source link

Updated to automatically update on detecting a change to default route #899

Closed tfwiii closed 2 years ago

tfwiii commented 2 years ago

Hello again

I've rewritten to use threading allowing updates of the widget when a change to default route is detected.

I use VPNs quite a lot with work and being able to see changes to my public IP in (near) real time is quite important. I understood that you didn't want the public geolocation API endpoints to be polled more frequently than necessary so thought this would be a good solution.

I also took the liberty of adding "contributed by tfwiii <https://github.com/tfwiii>_ - many thanks!" to the updated rst info - I hope that is ok!

tobi-wan-kenobi commented 2 years ago

Thank you very much for this contribution!

I am sick right now, so reviewing this will take a bit longer (esp.due to the changeset size). In the meanwhile: I think there are helpers for threading, but I cannot recall where exactly... Maybe in the speedtest module. Might make the code a bit easoer.

Thanks for the patience and sorry for the delay!

tfwiii commented 2 years ago

Thank you very much for this contribution!

I am sick right now, so reviewing this will take a bit longer (esp.due to the changeset size). In the meanwhile: I think there are helpers for threading, but I cannot recall where exactly... Maybe in the speedtest module. Might make the code a bit easoer.

Thanks for the patience and sorry for the delay!

Sorry to hear that! Get well soon :)

tobi-wan-kenobi commented 2 years ago

Looks good to me, many thanks!