search

tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.2k stars 229 forks source link

publicip module - Fixed bug and minor improvements in output #933

Closed tfwiii closed 1 year ago

tfwiii commented 1 year ago

Handled fail where core.location does not provide values for latitude and longitude. Added handling for coordinates N, S, E, W.

tobi-wan-kenobi commented 1 year ago

thank you very much for the PR!

I addes 2 small remarks in the code directly, once we address those, the PR is ready to be merged, from my PoV.

tfwiii commented 1 year ago

Can't see you comments but presume they related to the debugging prints I had left in the code. Apologies for that, they are now removed!

tobi-wan-kenobi commented 1 year ago

thanks! exactly :)

the other thing i don't understand is line 129. to my understanding, lon and lat are never initialized, am i missing something? so basically, it wozld always display unknown, because the fields are not extracted from __info.

maybe it is just the github formatting, i am on mobile right now.

tfwiii commented 1 year ago

I think you're right! I'm sorry, I rushed this before going out and I obviously didn't test it enough. Let me take another look when I get home and I'll update...

tobi-wan-kenobi commented 1 year ago

thank you kindly!

tobi-wan-kenobi commented 1 year ago

Looking good now, thank you very much for your contribution!