tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.2k stars 229 forks source link

allow setting sink ID in pipewire module #977

Closed jebaum closed 11 months ago

jebaum commented 11 months ago

Improvement

currently the pipewire module only works with whatever the default audio sink is if you use multiple sinks or easyeffects, this may not let you achieve the behavior you want allow passing a sink ID, and fall back to the current behavior if no argument is passed

jebaum commented 11 months ago

not quite sure why the tests are failing, at first glance it doesn't look related to the PR content

tobi-wan-kenobi commented 11 months ago

Changes look good, thank you kindly for the PR!

Yeah, the tests fail since some time, unfortunately, didn't have time to investigate yet....