search

tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.2k stars 229 forks source link

Fix: pipewire.py module #980

Closed sazk07 closed 11 months ago

sazk07 commented 11 months ago

mousewheel up and down events were initially not working on my bumblebee status bar. After verifying on the command line, it seems that wpctl set-volume command requires sink ID first and percentage change as the second arg.

steps to verify, assuming wireplumber is installed and sink ID is 32

wpctl set-volume 32 50%

will set the volume to 50%

wpctl set-volume 50% 32

will result in Object '52' not found

After switching self.__change and self.__id, mousewheel up and down events worked as expected increasing and decreasing volume.

I also wanted to take the opportunity to ask you if we can write python modules using f-strings instead of the str.format() for better readability? I believe this will break compatibility with Python versions <3.6 as f-strings were introduced in Python v3.6.

tobi-wan-kenobi commented 11 months ago

Thank you very much for the contribution and good find!