search

tobi-wan-kenobi / bumblebee-status

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.
https://bumblebee-status.readthedocs.io/en/main/
MIT License
1.2k stars 229 forks source link

Adding shell command execution on click for shell module #990

Closed Dronte closed 9 months ago

Dronte commented 9 months ago

Adding shell.left_click_command and shell.right_click_command to run commands upon clicking on the shell-module widget

tobi-wan-kenobi commented 9 months ago

There are generic "left-click" and "right-click" args for every module that should cover this functionality already.

Can you please give those a try?

Dronte commented 9 months ago

Ah, yes that works... my bad

What do you think about adding this line to those? That speeds up label update. https://github.com/tobi-wan-kenobi/bumblebee-status/pull/990/files#diff-8468fc6b35cfcdabccba415c8ef2dce3e768406f610d9b0f0137413c69bc0cc2R84

And do you find this useful?

https://github.com/tobi-wan-kenobi/bumblebee-status/pull/990/files#diff-f382f1f4b92c00b3b4fe465bcc2aaa3b85d110ce92833a49cb008bfc008c686bR58

Dronte commented 9 months ago

Side question: what do you think about same functionality for every widget in shortcut module?

tobi-wan-kenobi commented 9 months ago

I have added the two improvements you mentioned, I like them a lot, many thanks!

Regarding shortcut: @Dronte I don't think I follow, what do you mean? The additional call to "update"?

Dronte commented 9 months ago

This is awesome, thanks for shipping it.

Sorry, I wasn't clear at all on the shortcut module, opened an issue, let's discuss it there? https://github.com/tobi-wan-kenobi/bumblebee-status/issues/993