Similar improvements in JFX 19

tobiasdiez / EasyBind

Custom JavaFX bindings made easy with lambdas.

BSD 2-Clause "Simplified" License

30 stars 6 forks source link

Similar improvements in JFX 19 #63

Open tobiasdiez opened 2 years ago

tobiasdiez commented 2 years ago

There have been recently similar improvements to the core of JFX: https://github.com/openjdk/jfx/commit/60c75b82a4e1523b108fa79f44084190d78f5be1

Todo:

[ ] Point people to the new methods in the readme: EasyBind.map (similar to map but differs in handling of null) and EasyBind.mapObservable (similar to flatMap, but different handling of null)
[x] Keep compatibility due to conflicting name: done in #68

Siedlerchr commented 2 years ago

Easiest way: Rename the methods to avoid ambiguity. We can deprecate map and flatMap, I think. I would keep the OptionalBinding as there is no equivalent.

Siedlerchr commented 2 years ago

For testing with javafx19, it's easiest way is to use the javafx plugin for gradle and set the version to '19-ea+10' https://mvnrepository.com/artifact/org.openjfx/javafx-base/19-ea+10

tobiasdiez commented 2 years ago

Renaming sounds like a good idea indeed.

tobiasdiez commented 2 years ago

@Siedlerchr the new snapshot should be compatible with jfx 19. Can you please test this with JabRef?

Siedlerchr commented 2 years ago

Will test later this evening.

Siedlerchr commented 2 years ago

I noticed there was one or Else method that Still clashed. Created a follow up pr