tobiasdiez / EasyBind

Custom JavaFX bindings made easy with lambdas.
BSD 2-Clause "Simplified" License
30 stars 6 forks source link

Compatibility with jfx19 #68

Closed Siedlerchr closed 2 years ago

Siedlerchr commented 2 years ago

I simply renamed them with the suffix Opt

calixtus commented 2 years ago

Any chance this is getting merged soon. @tobiasdiez ? Java 19 will be released in 2 weeks...

Siedlerchr commented 2 years ago

@calixtus jfx != jdk 19 They are independent. Nonetheless, jfx19 will be released in September Suggestion: Piblish it as a new major release due to breaking changes and say that non-jfx19 users can still use the previous version

tobiasdiez commented 2 years ago

The rename looks good to me, but it needs a bit more cleanup before we can merge it. In particular,

Siedlerchr commented 2 years ago

Javafx 19 is here: https://twitter.com/GluonHQ/status/1569648445157146626

tobiasdiez commented 2 years ago

For the release notes:

## JavaFX 19 - Breaking Changes

JavaFX 19 introduced new methdods `flatMap`, `map`, `orElse`, `filter` which conflict with the methods from EasyBind. In contrast to the EasyBind implementation they do return `null` and not Optional. Therefore the methods from EasyBind have been renamed with the suffix `opt` to avoid conflicts.
You therefore have to rename the methods in your code to match the renamed.
tobiasdiez commented 2 years ago

Thanks!