Closed floroz closed 1 year ago
Merging #69 (050d826) into main (498c646) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 3 3
Lines 337 337
Branches 56 56
=======================================
Hits 315 315
Misses 22 22
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
It's only a type import, so the package strictly speaking doesn't depend on either builder. The point is more that only vite is supported as of now but not webpack. I've added the old vite builder. Do you think my changes are okay?
It's only a type import, so the package strictly speaking doesn't depend on either builder. The point is more that only vite is supported as of now but not webpack. I've added the old vite builder. Do you think my changes are okay?
Hey @tobiasdiez, thanks for the explanation. Yes, the changes look good.
So, based on what you are saying, it won't be a breaking change since we're not replacing one builder (builder-vite) for another, but updating support for types of the most recent builder (vue3-vite).
I've updated the commits to reflect that (and remove breaking change annotation).
Okay perfect, then let's get this in immediately.
Expand types to support modern
vue3-vite