Remove spaces from player name

[tobiasvl]

dialog.asm:

.noSFX
    ld   d, $00                                   ; $25E0: $16 $00
    cp   "#" ; character of player name           ; $25E2: $FE $23
    jr   nz, .notName                             ; $25E4: $20 $22
    ld   a, [wNameIndex]                          ; $25E6: $FA $08 $C1
    ld   e, a                                     ; $25E9: $5F
    inc  a                                        ; $25EA: $3C
    cp   NAME_LENGTH                              ; $25EB: $FE $05
    jr   nz, .notOver                             ; $25ED: $20 $01
    xor  a                                        ; $25EF: $AF
.notOver
    ld   [wNameIndex], a                          ; $25F0: $EA $08 $C1
    ld   hl, wName                                ; $25F3: $21 $4F $DB
    ld   a, [wIsThief]                            ; $25F6: $FA $6E $DB
    and  a                                        ; $25F9: $A7
    jr   z, .notThief                             ; $25FA: $28 $03
    ld   hl, .ThiefString                         ; $25FC: $21 $B8 $25
.notThief
    add  hl, de                                   ; $25FF: $19
    ld   a, [hl]                                  ; $2600: $7E
    dec  a                                        ; $2601: $3D
    cp   "@"                                      ; $2602: $FE $FF
    jr   nz, .handleNameChar                      ; $2604: $20 $02
    ld   a, " "                                   ; $2606: $3E $20
.handleNameChar

[tobiasvl]

• change so nameentrycharmap " " = $20 + 1, "@" = $00
• in dialog.asm: if name char is "@", add 1 to padding and skip to next char with jr .noDiacritic
• bonus: change name entry so B deletes current char (replaces with @) and " " inserts $20 + 1 (perhaps also make the cursor vertical)

[tobiasvl]

bonus optimizations:

dialog.asm:

• 2615 and 2644: ld d, 0 -> xor d
• 2639 and 2661: ld [hl], 0 -> xor [hl]
• 2656 and 2688: ld a, 0 -> xor a