Stop relying on GitHack for HTML builds

tobie / pr-preview

Adds preview and diff to spec pull requests.

Apache License 2.0

33 stars 16 forks source link

Closed tobie closed 2 years ago

tobie commented 2 years ago

Fixes #112

tobie commented 2 years ago

/cc @deniak

Does that seem sound from your perspective?

deniak commented 2 years ago

This looks good assuming the result will be served as text/html.

tobie commented 2 years ago

If you mean when they’re served from the AWS S3 instance, then yes.

deniak commented 2 years ago

If you mean when they’re served from the AWS S3 instance, then yes.

Ok, then LGTM

deniak commented 2 years ago

Thanks @tobie! This will help all the editors relying on pr-preview.