tobie / pr-preview

Adds preview and diff to spec pull requests.
Apache License 2.0
33 stars 16 forks source link

Error not surfaced properly #149

Closed TallTed closed 8 months ago

TallTed commented 8 months ago

See w3c/vc-data-model#1429.

tobie commented 8 months ago

Should now be fixed. You'll have to slightly edit the PR's body to kickstart a new build.

tobie commented 8 months ago

Reopening as the fix I landed doesn't work.

Closing again as a duplicate of #148.

TallTed commented 8 months ago

Not actually a duplicate as noted in https://github.com/tobie/pr-preview/issues/148#issuecomment-1925441234. Should have been reopened again.

Hopefully fixed for real as described in https://github.com/tobie/pr-preview/issues/148#issuecomment-1927210906.

tobie commented 8 months ago

Indeed, @TallTed, apologies for the mix-up. What were the odds of two entirely different issues with very similar profiles happening the very same weekend I was at FOSDEM!? Bigger than 0, apparently!