tobie / pr-preview

Adds preview and diff to spec pull requests.
Apache License 2.0
33 stars 16 forks source link

Error: 429 Too Many Requests from HTML Diff Service #153

Closed jyasskin closed 5 months ago

jyasskin commented 5 months ago

See w3ctag/privacy-principles#419 and https://github.com/w3ctag/privacy-principles/pull/417.

The error message includes "🔗 [Related URL]([object Object])", which is probably a bug in PR Preview itself. I'm not sure if the HTML Diff Service rate limit is PR Preview actually sending too many requests or the Diff Service being too restrictive.

gosko commented 5 months ago

I disabled rate-limiting for the htmldiff service if the user-agent contains pr-preview. Sorry for the hassle!

jyasskin commented 5 months ago

Confirmed as fixed in https://github.com/w3ctag/privacy-principles/pull/419. Thanks!