search

tobiipro / eslint-config-firecloud

The ESLint config used within Tobii Cloud Services.
http://eslint.org/
The Unlicense
2 stars 0 forks source link

review typescript rules overriding generic ones #39

Closed andreineculau closed 5 years ago

andreineculau commented 5 years ago

because at least one @typescript-eslint/no-unused-vars is not a superset of no-unused-vars, and thus we should not set no-unused-vars: off

https://github.com/tobiipro/eslint-config-firecloud/blob/master/configs/typescript.js#L97-L131

andreineculau commented 5 years ago

on a secondary look, it is a superset

https://github.com/typescript-eslint/typescript-eslint/blob/4edf0d7/packages/eslint-plugin/src/rules/no-unused-vars.ts#L22