search

tobiipro / lodash-firecloud

Collection of lodash mixins.
Apache License 2.0
0 stars 1 forks source link

add filterOut and keep #7

Closed andreineculau closed 5 years ago

IanSavchenko commented 5 years ago

I see you are having some fun :) What about existing _.reject comparing to filterOut? And your keep is the same as _.remove, but with falsy predicate? Never thought that you are a fan of syntax sugar :)

andreineculau commented 5 years ago

Naming... Yup. No need for.filterOut, it's the same as .reject

Maybe .keep has an equivalent too? I guess i have to search the codebase, their namings and me don't blend apparently, proof is your .reject find.

PS: it's not for me but i saw this coming for enforcing immutable methods and we (maybe because is me not knowing about reject) use filter and remove as counterparts. I needed an immutable remove so that we don't start writing .filter .negate .iteratee everywhere 🤦‍♂️ funny that the author didn't mention it in his reply 😉. I don't have a drive for a mutable .keep so i think i will close the issue. Best way to end a PR "Closing, functionality exists already. You just didn't read the docs (properly)" 😂

-- Andrei Neculau Software Developer @ Tobii Pro (Cloud Services)

8 dec. 2018 kl. 13:12 skrev Ian Savchenko notifications@github.com<mailto:notifications@github.com>:

I see you are having some fun :) What about existing .reject comparing to filterOut? And your keep is the same as .remove, but with falsy predicate? Never thought that you are a fan of syntax sugar :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tobiipro/lodash-firecloud/pull/7#issuecomment-445454610, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AArOQajkAMCxBxDy_Np7IGXytB2N1npcks5u26ydgaJpZM4ZJmf6.