tobiipro / support-firecloud

Software and configuration that support TobiiPro's Cloud Services development.
Apache License 2.0
4 stars 1 forks source link

`make docker-ci` improvements #163

Open andreineculau opened 4 years ago

andreineculau commented 4 years ago

cc @spschlegel cc @weetmuts no 4 would be the intermediary step for creating repo-based docker images

tobiiasl commented 4 years ago

Not sure if it is related to this PR but I noted that we explicitly check against TRAVIS env vars in the sf_run_docker_ci_image() function (see https://github.com/tobiipro/support-firecloud/blob/master/repo/ci.sh/before-install.pre.inc.sh#L21-L22).

I guess that should be abstracted in some way.