Open andreineculau opened 4 years ago
Not sure if it is related to this PR but I noted that we explicitly check against TRAVIS env vars in the sf_run_docker_ci_image()
function (see https://github.com/tobiipro/support-firecloud/blob/master/repo/ci.sh/before-install.pre.inc.sh#L21-L22).
I guess that should be abstracted in some way.
:cached
make nuke deps build
inside docker, and then once again outside docker, when finished). You might be good to go mounting therepo/.git
folder instead of runninggit checkout .
inside docker. This way, still have access to the whole git history, but you have a separate checkout instanceAWS_*
orGH_TOKEN
from the host to the docker containermake docker-ci
needs to be followed by a./.ci.sh before_install
to install required system dependencies, plus it can take a long time to create GIDs and do recursive chown, etc so ideally there would be amake docker-ci/scratch
andmake docker-ci
where the latter would actually make use of an existing local image based on SF_DOCKER_CI_IMAGE + GIDs/etc +./.ci.sh before_install
cc @spschlegel cc @weetmuts no 4 would be the intermediary step for creating repo-based docker images