search

tobijk / caius

A functional testing framework in object-oriented Tcl
MIT License
26 stars 5 forks source link

Escaping apostrophes #13

Closed wduquette closed 9 years ago

wduquette commented 9 years ago

One of things I'm doing is running caius/Markdown against the mdtest tool's Markdown.mdtest; and one of the differences I see is that caius/Markdown escapes apostrophes as "'", which causes a false negative in the test suite. It's not wrong, certainly, but I'm never run into any problems with unescaped apostrophes, and I was wondering why you bothered.

tobijk commented 9 years ago

Honestly, I don't remember. Probably I just took all the default entities for XML and escaped them. Since generated XHTML attributes are always framed by double-quotes, it should be safe to not escape the apostrophes. So let's get rid of that.

For some reason it never occurred to me to look for an existing test suite and started maintaining my own, but clearly I missed a lot of corner cases. I will check against mdtest.

tobijk commented 9 years ago

This has been "fixed".