search

tobilg / facebook-events-by-location-core

[DEPRECATED] Search Facebook events by location and proximity.
MIT License
141 stars 56 forks source link

Introduce correct location #15

Closed alexpopa95 closed 7 years ago

alexpopa95 commented 7 years ago

Place location and venue location could be different. Place location defines the exact event location

tobilg commented 7 years ago

I don't really think it makes sense to replace the the page/venue location with the event location. When a user searches for a place, the search will return results for the page/venue first, and as a second step the tool queries for events. If those events contain another place than the page/venue, and we set this now as new place, then it would subsequently not adhere to the initial search parameters.

tobilg commented 7 years ago

Also see https://github.com/tobilg/facebook-events-by-location-core/issues/7

alexpopa95 commented 7 years ago

@tobilg Yeah :) Thank you! I didn't see that issue. I now understand why you do not want to do this. Either way, it would be cool to have a solution that return the location where the event actually takes place, in a consistent way of course. I'm using this data in a mobile application and the place location for me is necessary.

I've made some tests and the solution in the pull works fine for me.. with no data outside the specified bounds.

I'll let you know if I come up with something else if you think this could be useful