search

tobilg / marathon-slack

Integration for Marathon's Event Bus with Slack
MIT License
42 stars 23 forks source link

Send messages on events where the marathon appId matches given regex #12

Closed eodgooch closed 7 years ago

eodgooch commented 7 years ago

In a large data-center the operations team would like to be notified of marathon events matching some Regular Expression pattern. This pull request allows users to specify a Marathon env var APP_ID_REGEXS which is a comma separated list of strings to filter events by.

tobilg commented 7 years ago

Thanks for the PR! Could you please add an example of the usage to the Readme as well?

tobilg commented 7 years ago

Do you also need an update of the DC/OS Universe package @eodgooch?

eodgooch commented 7 years ago

I'll go ahead and update the DC/OS package once you approve updates. What version tag? 0.3.2?

I am also considering adding an env var to log events. Not sure if this is something you want in the project. My goal is to log events to get picked up by our shipper and sent to ES. Let me know.

tobilg commented 7 years ago

I implemented the desired changes in https://github.com/tobilg/marathon-slack/commit/af88c18c77ed0563b90b660750df986c03b310fa The Docker image is currently building in version 0.4.0.