search

tobilg / marathon-slack

Integration for Marathon's Event Bus with Slack
MIT License
42 stars 23 forks source link

Ability to filter by group and/or app #3

Closed alenkacz closed 7 years ago

alenkacz commented 8 years ago

I would like to filter events by an apo group or name of the app.

I am happy to submit PR if that sounds good...

tobilg commented 8 years ago

Sounds interesting...! How would you imagine the definition of the filters? Comma-separated list? Would you have two filters, one for apps and one for groups?

alenkacz commented 8 years ago

Exactly. Comma separated, two different filters.

tobilg commented 8 years ago

Ok, sounds good :-) I'd be happy to receive a PR. Do you use this on plain Mesos/Marathon, or DC/OS?

tobilg commented 8 years ago

Sorry, one more thing: It would be great if the filters can be defined via environment variable, as then others already work. Thanks!

tobilg commented 8 years ago

Another requirement would be that there needs to be a default value * which signals that all app or groups shall be used. This is necessary for the DC/OS Universe package, which needs default values.

tobilg commented 7 years ago

Hi @alenkacz, just a quick question: Are you still interested in providing a PR? Otherwise I'd close this issue because I currently don't have time to implement it myself. Thanks!

alenkacz commented 7 years ago

@tobilg yes, sorry. I am busy eith another project but I will finish this soon

tobilg commented 7 years ago

No problem @alenkacz! Just wanted to check whether it's still relevant... Thanks for your efforts!

tobilg commented 7 years ago

Close due to inactivity.