tobimori / kirby-dreamform

✨ DreamForm is an opiniated form builder plugin for Kirby CMS that makes forms work like magic
https://plugins.andkindness.com/dreamform
45 stars 7 forks source link

Preview link broken on files uploaded with Dreamform (getkirby/kirby#6786) #98

Open samlinck opened 2 weeks ago

samlinck commented 2 weeks ago

When clicking on the preview button nothing happens. The preview button of other files does work as expected. When manually copying the file url the file can be accessed.

image

Also in the default mail message, nothing is said about a file being uploaded. Could be an enhancement to provide a link to the uploaded file?

image
tobimori commented 2 weeks ago

In DreamForm 1.5.0 you can choose to add the files as attachment to the email. It's not possible to add the links to the email since the file is uploaded/created in Kirby after the email is send. See more here.

tobimori commented 2 weeks ago

Honestly, I'm a bit confused about this report, it works fine on my environments - both with images and other file types.

samlinck commented 2 weeks ago

Okay very nice that it will be available in 1.5.0! It's indeed a strange bug, maybe some other plugin or setting is conflicting with it. I will let you know if I know some more.

samlinck commented 2 weeks ago

So the weird thing is, that the preview button isn't a link for me. image

tobimori commented 2 weeks ago

I just found the same issue with some video files that were normally uploaded via the panel - unrelated to DreamForm. Seems like a Core bug?

samlinck commented 1 week ago

I opened a new issue: https://github.com/getkirby/kirby/issues/6786

dominiklaube commented 1 week ago

I had this issue in other contexts with Kirby one day ago. If you upload a file to a page with a blueprint, where the blueprint permisson for preview is set to false, then this happens.

Also the fiel preview urls follow some more conditions - see here https://github.com/getkirby/kirby/blob/eb47158e91e74184ab291ede020664f1d2829f74/src/Cms/File.php#L652