search

tobimori / kirby-icon-field

🏷️ A simple Icon field plugin for Kirby CMS.
https://getkirby.com/plugins/tobimori/icon-field
MIT License
38 stars 4 forks source link

Minor style adjustments #4

Closed timnarr closed 1 year ago

timnarr commented 1 year ago

Hi Tobias,

thank you for this plugin and all your other Kirby plugins 🙌

I made two minor improvements to the iconinput styles to fix the following two cases:

1: Icons not fitting the parent container when width and height are greater than 1rem or icons not being in 1:1 ratio. Please take a look at the following screenshot. I've added a red background for the not fixed version so it's easier to spot the problem. You can see that the deviantart, discourse, and dochub icons are overflowing the parent container. See this commit.

iconinput

2: SVG icons with colors other than white or without any color information. Currently all icons are displayed in the color defined in the SVG in fill or stroke attributes or even in inline styles. Depending on the color chosen there, the contrast in the panel is very poor. Some icons, such as those from fontAwesome, have no color information at all and are displayed in black. Since the Mulitselect dropdown is black too, you don't see these icons at all. I've added a CSS filter to convert everything to white no matter how the icon was styled originally. See this commit

tobimori commented 1 year ago

Thanks for your PR! I'm currently traveling through Europe (in Budapest right now, next stop is Rijeka) - so it might take me a while to review it, but the changes are very welcomed. Are you using the plugin with Kirby v3?

timnarr commented 1 year ago

No worries, there's no hurry. Yes, using it with Kirby v3 Enjoy your trip!