Field label language fallback doesn't work

olach commented 1 week ago

If the panel user has a language that is not included as a translation for this plugin, the field labels shows the label keys instead of a fallback translation.

To reproduce:

For the currently logged in user, set the user language to a language that is not supported by this plugin, i.e. Swedish.
Go to a page and show the SEO tab.
All field labels shows the label key: global-meta-headline, meta-title-template, meta-title-template-help, meta-description etc

I would rather see that if the user language is not supported, the fallback would be shown with English translation.

tobimori commented 1 week ago

This doesn't seem like a plugin issue but rather an issue of core. Surely it should work by default? https://github.com/getkirby/kirby/issues/1188

olach commented 1 week ago

I was also thinking it might be a Kirby issue. Forgot to mention that. But because of this issue I took the time to make a PR with a swedish translation. So something good came out of it. 😄

tobimori / kirby-seo

Field label language fallback doesn't work #120