search

tobischo / gokeepasslib

A library to read and write keepass 2 files written in go
MIT License
251 stars 30 forks source link

some optimization of salsa #85

Closed zenyusy closed 5 months ago

tobischo commented 2 years ago

How big is the actual optimization? Did you measure it?

Do you have a use case where it matters sufficiently for me to accept this PR instead of leaving it as is?

Basically there is not much context given about why this optimization is needed. From my very subjective perspective it does not improve readability to me and I do not have a use case where I would need salsa to be more optimized here, as the difference is probably marginal when I am just reading 1 file at a time with maybe a few hundred entries

tobischo commented 5 months ago

Closing due to lack of response. I also since added some other changes to it, which are conflicting here.