tobmaps / TrinityCore

http://www.TrinityCore.org
GNU General Public License v2.0
38 stars 7 forks source link

Sweeping Strikes + Bladestorm #200

Open oMadMano opened 13 years ago

oMadMano commented 13 years ago

What steps will reproduce the problem?

  1. Roll a warrior, get close to enemy, use Sweeping Strikes http:// www.wowhead.com/spell=12328
  2. Target yourself
  3. Use Bladestorm http://www.wowhead.com/spell=46924

Sweeping strikes hit the enemy after every hit of bladestorm. They shouldn't.

This is an exploit that anybody can use when there are more than 1 target it seems to work well even if is player + player or player+pet the problem is that you can use this as an exploit on one target and this can be a pain in the ass on arena

Suggestion: somehow we need to make this to proc only if thers 2 enemy and you should not count here maybe something like this but im not sure :(

case 12328: // Sweeping Strikes spellInfo->EffectImplicitTargetA[0] = TARGET_UNIT_AREA_ENEMY_SRC; spellInfo->EffectImplicitTargetB[0] = TARGET_UNIT_AREA_ENEMY_SRC; spellInfo->EffectRadiusIndex[0] = 30; ++count; break;

its not hard to fix but i need your help or suggestion to understand how to fix it so please take a look on it

More info can be found here http://code.google.com/p/trinitycore/issues/detail?id=1821 sorry for copy pasting but it is an important exploit that can be done with this just like master's call

kbinside commented 13 years ago

FIRST Fix Sweeping Strikes it Self, couse now it does low damage. SS does not copy correct damage from hits, always copy as non crit hit damage.

example: if i hit with mortal strike for 2k, ss should copy its damage and hit for 2k with ss. if i crit mortal strike, example 3k critical hit, ss will hit 3k too, but it will be not critical, couse ss copy damage and that damage cant be critical again.

for now ss always do low damage, if i crit 3k, ss will copy wrong damage, like it wasnt a critical hit. it look like this for now: mortal strike critical 3k sweeping strikes 1.5k, when it should be 3k. (that is the bug) wrong damage copying.

oMadMano commented 13 years ago

ss dosent crit or at least should not crit anyways but nvm

kbinside commented 13 years ago

dude read again what i wrote.