search

tobmaps / TrinityCore

http://www.TrinityCore.org
GNU General Public License v2.0
38 stars 7 forks source link

[Warrior] T10 4P Bonus #25

Open Jildor opened 13 years ago

Jildor commented 13 years ago

It's bug

I think this fix solves:

http://www.trinitycore.org/t/trinitycore/ticket/449#comment:7

tobmaps commented 13 years ago

this patch isn't working properly. I does remove all charges at using Slam and Execute and Slam proc doesn't has 2 charges

Jildor commented 13 years ago

Oks.

So, any solution?

thx

tobmaps commented 13 years ago

it's not so easy to fix charge consuming for this... I'm no planning to fix it for a while, i more prefer to fix talents and player spells ^^

Jildor commented 13 years ago

mmmm

Are you applied the sql to patch? http://www.trinitycore.org/t/trinitycore/attachment/ticket/449/patch.sql I think works.

tobmaps commented 13 years ago

yes i've applied this, but anyway this SQL will not fix bugs that i meant before

Jildor commented 13 years ago

I count as 2 charges and I removed one at a time....I don't know :S

kbinside commented 13 years ago

important bug, waiting for fix.

Jildor commented 13 years ago

possible fix? https://github.com/SignFinder/FaceCore/commit/085c8d8d17bfd92595db8a47ec3d93e622be9ef8

kbinside commented 13 years ago

great, add this.

tobmaps commented 13 years ago

this fix is a one big hack, correct solution can be done when QAston will done his new proc system

kbinside commented 13 years ago

its about time, to make this bonus working?

tobmaps commented 13 years ago

better to wait for implementation of new proc system by QAston and only then try to fix it. For now you can easily use any hack that you want, i just will not review it

kbinside commented 13 years ago

okey, keep waiting.

maybe you can check: https://github.com/TrinityCore/TrinityCore/issues/2014 thanks