Bring code up to date with dependencies/requirements

tobof / openhab-addons

The next-generation open Home Automation Bus (openHAB)

Eclipse Public License 2.0

39 stars 30 forks source link

Bring code up to date with dependencies/requirements #111

Closed freynder closed 6 years ago

freynder commented 6 years ago

This PR contains the changes required to be able to compile to plugin.

wmarkow commented 6 years ago

@freynder - if I understand correctly - your PR contains two main things:

Merge remote-tracking branch 'upstream/master' into MySensors_Binding with commit ea11c67
Bring code up to date with dependencies/requirements with commit e303975. Actually changes from this commit make that MySensors binding follows to the openhab development (and it is possible to build by the way)

Is that correct? If so then it needs to be improved further as current openHAB version under development is 2.4.0-SNAPSHOT. Anyway your PR helped me to understand a bit.

freynder commented 6 years ago

@wmarkow : Hi, regarding https://github.com/tobof/openhab2-addons/pull/111/commits/e30397506d2337c2dea68da48d84baa72feed6b1: those were the minimal changes required to make it compile without major errors. I'm not sure if it completely follows openhab development guidelines.

wmarkow commented 6 years ago

Thanks @freynder. That's good enough for me. For now I just want to compile MySensors Openhab binding.

tobof commented 6 years ago

Hey @freynder !

Thank you for your PR. I've made similar changes in my development environment but wassn't able to upload those changes because of a stay in hospital. :-/ I've uploaded my changes now and it seems to me, that we have done the same work. I'm very sorry for that.

freynder commented 6 years ago

No worries, I needed to compile it so I thought I would share it just in case. Thanks for your great work!