tobof / openhab-addons

The next-generation open Home Automation Bus (openHAB)
Eclipse Public License 2.0
39 stars 30 forks source link

Node search randomly ignores presentations #118

Closed Avamander closed 6 years ago

Avamander commented 6 years ago

Current behaviour:

As the title already describes, I'm seeing from the logs how node presents and sends node data but the search functionality absolutely ignores it, I'm not getting a message to inbox that says there's a sensor that could be added. I would absolutely gladly provide other information about the setup if that's needed.

Expected behaviour:

I get a message to paper UI's inbox.

Software:

Log:

2018-07-07 17:28:57.716 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 5;20;1;0;16;1
2018-07-07 17:28:57.717 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Node 5 found in gateway
2018-07-07 17:28:57.719 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Child 20 found in node 5
2018-07-07 17:28:57.733 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3922287 TSF:MSG:READ,5-5-0,s=20,c=1,t=16,pt=1,l=1,sg=0:1
2018-07-07 17:28:57.736 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3922293 TSF:MSG:ACK REQ
2018-07-07 17:28:57.738 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3922298 TSF:MSG:SEND,0-0-5-5,s=20,c=1,t=16,pt=1,l=1,sg=0,ft=0,st=OK:1
2018-07-07 17:28:57.740 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 5;20;1;0;16;1
2018-07-07 17:28:57.742 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Node 5 found in gateway
2018-07-07 17:28:57.743 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Child 20 found in node 5
2018-07-07 17:28:58.723 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3923275 TSF:MSG:READ,5-5-0,s=20,c=1,t=16,pt=1,l=1,sg=0:0
2018-07-07 17:28:58.725 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3923281 TSF:MSG:ACK REQ
2018-07-07 17:28:58.727 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3923286 TSF:MSG:SEND,0-0-5-5,s=20,c=1,t=16,pt=1,l=1,sg=0,ft=0,st=OK:0
2018-07-07 17:28:58.729 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 5;20;1;0;16;0
2018-07-07 17:28:58.731 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Node 5 found in gateway
2018-07-07 17:28:58.732 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Child 20 found in node 5
2018-07-07 17:28:58.734 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3923294 TSF:MSG:READ,5-5-0,s=20,c=1,t=16,pt=1,l=1,sg=0:0
2018-07-07 17:28:58.743 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3923300 TSF:MSG:ACK REQ
2018-07-07 17:28:58.745 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3923305 TSF:MSG:SEND,0-0-5-5,s=20,c=1,t=16,pt=1,l=1,sg=0,ft=0,st=OK:0
2018-07-07 17:28:58.747 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 5;20;1;0;16;0
2018-07-07 17:28:58.748 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Node 5 found in gateway
2018-07-07 17:28:58.750 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Child 20 found in node 5
2018-07-07 17:28:59.732 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3924281 TSF:MSG:READ,5-5-0,s=20,c=1,t=16,pt=1,l=1,sg=0:1
2018-07-07 17:28:59.734 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3924287 TSF:MSG:ACK REQ
2018-07-07 17:28:59.735 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3924291 TSF:MSG:SEND,0-0-5-5,s=20,c=1,t=16,pt=1,l=1,sg=0,ft=0,st=OK:1
2018-07-07 17:28:59.737 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 5;20;1;0;16;1
2018-07-07 17:28:59.739 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Node 5 found in gateway
2018-07-07 17:28:59.740 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Child 20 found in node 5
2018-07-07 17:28:59.742 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3924298 TSF:MSG:READ,5-5-0,s=20,c=1,t=16,pt=1,l=1,sg=0:1
2018-07-07 17:28:59.744 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3924305 TSF:MSG:ACK REQ
2018-07-07 17:28:59.751 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;3924310 TSF:MSG:SEND,0-0-5-5,s=20,c=1,t=16,pt=1,l=1,sg=0,ft=0,st=OK:1

EDIT: I removed literally all the children and liked items. Now it's child with ID 18, presentation is ignored for it (no things have yet been added), when reading is sent log shows:

2018-07-07 17:57:34.785 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 5;16;1;0;23;879
2018-07-07 17:57:34.787 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Node 5 found in gateway
2018-07-07 17:57:34.790 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Child 16 found in node 5
2018-07-07 17:57:35.864 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;5642468 TSF:MSG:READ,5-5-0,s=18,c=1,t=16,pt=1,l=1,sg=0:0
2018-07-07 17:57:35.867 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;5642474 TSF:MSG:ACK REQ
2018-07-07 17:57:35.888 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;5642478 TSF:MSG:SEND,0-0-5-5,s=18,c=1,t=16,pt=1,l=1,sg=0,ft=0,st=OK:0
2018-07-07 17:57:35.890 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 5;18;1;0;16;0
2018-07-07 17:57:35.892 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Node 5 found in gateway
2018-07-07 17:57:35.894 [DEBUG] [rs.internal.gateway.MySensorsGateway] - Child 18 not present in node 5
2018-07-07 17:57:35.896 [DEBUG] [rsAbstractConnection$MySensorsReader] - Message from gateway received: 0;255;3;0;9;5642486 TSF:MSG:READ,5-5-0,s=18,c=1,t=16,pt=1,l=1,sg=0:0
Avamander commented 6 years ago

I decided to "spam" the line present(18, S_DOOR, "", false); // Switch2 in presentation() (repeated it about 10 times with 100ms delay) and then it was finally seen by the gateway (only once). I do not understand why literally every other message was received successfully on first attempt but not that one.

Closing this as the real issue is lack of proper ACK support.