search

tobof / openhab-addons

The next-generation open Home Automation Bus (openHAB)
Eclipse Public License 2.0
39 stars 30 forks source link

Same parameter for all things (except the bridge) #63

Closed andreacioni closed 7 years ago

andreacioni commented 7 years ago

Hello @tobof ! I'm wondering to put in each "config-description" tag (inside thing-types file) all the parameters contained in MySensorsThingConfig.java . This allows user to set, for example, smartSleep to a Motion Sensor (it has the armed channel) and simplify, for us, the update of that file. I told you that because I'm now adding new configurable parameters and I've encountered some difficulties. Clearly I'll do this on "Refactoring" branch. What do you think? 😃

andreacioni commented 7 years ago

I'll attach here the resulting file.

tobof commented 7 years ago

Good idea!

In addition we should split the xml file. An approach like this one looks neat: https://github.com/openhab/org.openhab.binding.zwave/tree/master/ESH-INF/thing

andreacioni commented 7 years ago

Hmmm yes it will be more readable than now 👍 . Today I'll push the modification with updated thing-type file. We can leave open this ticket as a TODO for splitting that file later.