tobof / openhab-addons

The next-generation open Home Automation Bus (openHAB)
Eclipse Public License 2.0
39 stars 30 forks source link

MQTT Gateway support using openhab transport #75

Closed mcguiresean closed 7 years ago

tobof commented 7 years ago

I've tested sending and receiving messages via a broker configured in mqtt.cfg. That's really good work!

The binding is receiving messages, but there is a bug in the payload conversion. Sending of messages seems to work. I've not yet tested it against a MQTTGateway but will do so.

One thing to keep in mind is: the binding adds the need for org.openhab.transport.mqtt regardless if mqtt is used or not. Similar to org.openhab.transport.serial. It's no problem, but maybe we find a way to avoid this in the future.

mcguiresean commented 7 years ago

Hi @tobof , I've moved the string manipulations into the MySensorsMessage class by creating 2 new methods: parseMQTT and generateMQTTString. Hope this is what you meant?

tobof commented 7 years ago

Hey @mcguiresean !

After a lot of work to fulfill the requested changes needed for a integration into the official openhab2-addons repository, I'm now back to MQTT. :smile: Sorry for the long delay, but I needed to finish that one first.

The changes I've made now lead to conflicts with this PR. I think (and hope) it won't be that hard to resolve the conflicts. Please let me know if you've the time to look into it. Thank you!

mcguiresean commented 7 years ago

Superceded by PR #85