search

toboid / correlation-id

Correlation id for node.js
MIT License
47 stars 8 forks source link

Use runAndReturn to get result of function executed inside withId #24

Closed HEYGUL closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 176b24273f3a672787f0b54c4ef24af0e8449504 on HEYGUL:master into 5a431d791548e0afd1a47b185255da94778a0e04 on toboid:master.

toboid commented 6 years ago

@HEYGUL thanks for this. Would you mind adding for the bindId function too so that we can keep some symmetry?

Also we'll need to add tests for this functionality.

HEYGUL commented 6 years ago

I can add the same bindId function too. Regarding unit tests, I am not confortable with the tests in place. I can add tests but I would need adding mocha chai. Let me know if I can do it, otherwise, I would be glad to get help from you .

Edit: I had a look to ava and get enough understanding to add Unit Tests. Please have a look to latest commit ^^

toboid commented 6 years ago

published as 3.0.0

HEYGUL commented 6 years ago

Hi, I had a look to v3.0.0 and only CHANGELOG and README seem to have been updated. index.js and tests did not change. Any idea why ?

toboid commented 6 years ago

Sorry @HEYGUL this was error on my part. Now republished as 3.0.1 and changes are there this time

HEYGUL commented 6 years ago

Great! Everything is working fine now! Many thanks for your work. I wish all the best :-)