Some features & fixs - Githubissues

Caerind commented 10 years ago

Add SFX_ suffix to the block guard
Remove List, Game, MainMenu
Change the way to generate random number
Unlink AudioManager & Application
Change the name of some functions
Add getMousePixelToCoord() and setDefaultView() to Application

tobsa commented 10 years ago

Hi!

It's really nice and awesome of you to keep the development of this ongoing, and made me more excited to continue develop this myself! Altough I have a couple of questions regarding some changes (after a more carefully examination after I merged the pull request).

I noticed you changed the visibility from private to protected in several classes. I can't really see the purpose of this, why the change?

Why change the implementation of random numbers? Didn't it worked properly before? The float getRandom()-method also has some weird arbritary number (9999), this doesn't really work as it should, right?

Other than that, I really like all the changes! Thank you! Best regards, Tobias

Caerind commented 10 years ago

Hi !

I find your framework very interesting and while using it, I've seen some things that make problems.

First, how i change the private to protected ? I wanted Application to inherit from all the class you made. That's also why I've changed the name of some functions and unlink the audiomanager. And on my side, I use a proper class Application which inherit from sfx::Application so the protected is better and work like private for encapsulation.

Next, for random number, the way you handled it doesnt work with every compiler but I know that my way isn't the best... My way isn't made at all for float numbers... I pasted the code from a forum I don't remember where so it can be wrong

I'm actually trying to find another way which can work everywhere and well.

You did a really great job on this framework :)

Charles

tobsa / SFML-Framework

Some features & fixs #2