do not load jquery.js inside mediaelement.js

tobsch / mediaelement_rails

An easy as hell mediaelementjs rails integration for asset pipeline enabled apps...

MIT License

106 stars 49 forks source link

do not load jquery.js inside mediaelement.js #12

Closed aka47 closed 10 years ago

aka47 commented 11 years ago

Do not require jquery.js inside this gem!

This causes big trouble for almost everybody, since they will already do this somewhere else!! So you end up with 2 jquery versions, but have no idea about that fact. Plus the uses loads 2 times jquery.

Plus i changed files to vendor dir, since it is the standard location. And i namespaced rails.js, not sure if that was needed.

boxofrad commented 11 years ago

+1 this causes all kinds of pain

tobsch commented 11 years ago

jquery is removed now. the thor file has to be changed aswell to match your directory changes. could you do that?

aka47 commented 11 years ago

not sure what we mean and if you mean me?! Can you help me :)

hearthis commented 11 years ago

Has this been done?

fusion2004 commented 10 years ago

This was fixed in 06d4bc8b84088e1a910207514321ad6b6122fdc6