search

toby / serde-bencode

Serde backed Bencode encoding/decoding library for Rust.
MIT License
65 stars 16 forks source link

Fix Rust 1.26 attribute regression #15

Closed toby closed 2 years ago

toby commented 6 years ago

From: https://github.com/rust-lang/rust/issues/49934

Looks like Rust 1.26 breaks our build.

chpio commented 6 years ago

maybe im just blind, but where's the error: https://cargobomb-reports.s3.amazonaws.com/beta-1.26.0-beta.2/beta-2018-04-06/reg/serde_bencode-0.2.0/log.txt

current master compiles/tests just fine on current nightly (1.27.0-nightly (ad610bed8 2018-04-11))

toby commented 6 years ago

@chpio I also didn't parse an error out of that. I was going to build it with 1.26 after work today to see what was up. If nothing else, this ticket can be to go back and tell them there's no problem :)

madadam commented 2 years ago

Minimal rust version required by this crate is now 1.40.0. I'm closing this, but feel free to create a new issue if you need it to support older rusts.