Closed madadam closed 3 years ago
Awesome! Thank you for this. I'm also looking for someone to help me to maintain this lib. Would you be interested?
Cool, thanks!
I'm also looking for someone to help me to maintain this lib. Would you be interested?
Sure, why not. Anything in particular you have in mind?
Cool, thanks!
I'm also looking for someone to help me to maintain this lib. Would you be interested?
Sure, why not. Anything in particular you have in mind?
General maintenance for the most part. I've been mostly focused on Go libraries, so haven't had the time to put into this one. I can add you as a maintainer.
This PR fixes the inability of this crate to deserialize into an adjacently tagged enum and also to a flattened adjacently tagged enum. The first was caused because the enum tag is handled using a visitor (defined inside serde itself) which only defines
visit_str
, but this crate'sDeserializer
forwardeddeserialize_str
intodeserialize_any
which in turn callsvisit_bytes
. The fix is to explicitly definedeserialize_str
which callsvisit_str
. The second issue is similar but needed explicit definition ofdeserialize_identifier
instead, also callingvisit_str
.This PR also applies
rustfmt
(with the default settings) in the first commit and fixes compiler and clippy warnings in the second. I believe this is useful to make future contributions to this project easier. If you disagree, I'm OK with taking those two commit out or to put them into a separate PR if you prefer.Closes #24